Skip to content

Use hy-delete-files-and-buffers - #1099

Merged
matsl merged 1 commit into
masterfrom
pr_fix_wikiword_created_in_interactive_tests
Nov 17, 2026
Merged

matsl merged 1 commit into
masterfrom
pr_fix_wikiword_created_in_interactive_tests

Conversation

@matsl

@matsl matsl commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

What

Reverting the part of commit f5b3791 that deletes the wiki-page. Not
sure why I concluded that had to be changed. The stock
hy-delete-files-and-buffers is better.

  • test/hywiki-tests.el (hywiki-tests--preserve-hywiki-mode): Use
    hy-delete-files-and-buffers for removing the wiki-page. Reverts the
    change in commit f5b3791.

Why

Some interactive tests fails to delete the wiki-page in unwind-protect
due to the change in f5b3791. As stated above - not sure how I
managed to convince my self that it was needed. The original code
works better.

Reverting the part of commit f5b3791 that deletes the wiki-page. Not
sure why I concluded that had to be changed. The stock
hy-delete-files-and-buffers is better.

* test/hywiki-tests.el (hywiki-tests--preserve-hywiki-mode): Use
hy-delete-files-and-buffers for removing the wiki-page. Reverts the
change in commit f5b3791.
@matsl matsl self-assigned this Nov 16, 2026
@matsl
matsl requested a review from rswgnu November 16, 2026 23:26
@matsl
matsl merged commit 9d2416e into master Nov 17, 2026
5 checks passed
@matsl
matsl deleted the pr_fix_wikiword_created_in_interactive_tests branch November 17, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants